send callbacks on dismissViewControllerAnimated completion

[jcesarmobile]

Changed barcodeScanDone method to use a block, so it sends the
callbacks to the javascript side when the barcode scanner view
controller has been completely dismissed.
It was causing problems with the dialogs plugin if you used a dialog on
the success or error callback as the barcode scanner view was being dismissed and couldn't present a dialog over it.

[tony--]

@jcesarmobile - Do you know if this PR is still relevant? Just wondering if this was addressed in some other way in 5.0.0...

[jcesarmobile]

I don't think this has been addressed in some other way.
The dialogs problem won't appear now because I fixed another bug on the dialogs plugin that avoids the presentation of the dialog on a ViewController that is being dismissed, but if this isn't merged, there can be problems with other plugins that might present a ViewController with the QR result (inAppBrowser comes to my mind if you scan an url and try to open it).

Now I have permissions on this repo and can merge it, but should figure out why Travis failed first.
I'm in the middle of a travel, so I'll try to take a look next week.

[daserge]

@jcesarmobile, I've restarted the build and it passed.

[jcesarmobile]

Thanks, I'll rebase because it has conflicts now, hope it passes again

[jcesarmobile]

Rebased

@EddyVerbruggen can you review it?

[EddyVerbruggen]

Look good, thanks! 👍

[jcesarmobile]

merged

[lock]

This thread has been automatically locked.