This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
[WinJS][Win10] Fixes "formats" in options passed to BarcodeReader.scan() being ignored #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed by WinJS implementation targeting Windows 10
macdonst
suggested changes
Sep 1, 2017
src/windows/BarcodeScannerProxy.js
Outdated
| @@ -157,6 +157,21 @@ BarcodeReader.prototype.init = function (capture, width, height) { | |||
| this._height = height; | |||
| this._zxingReader = new ZXing.BarcodeReader(); | |||
| this._zxingReader.tryHarder = true; | |||
|
|
|||
| const formatsList = BarcodeReader.scanCallArgs.args.length > 0 && BarcodeReader.scanCallArgs.args[0].formats; | |||
src/windows/BarcodeScannerProxy.js
Outdated
| var possibleFormats = formatsList | ||
| .split(",") | ||
| .map(format => { | ||
| for (let index in BARCODE_FORMAT) { |
macdonst
approved these changes
Sep 6, 2017
Mischa1610
added a commit
to sovanta/phonegap-plugin-barcodescanner-custom-ui
that referenced
this pull request
Oct 19, 2017
* phonegap/master: [readme] updating PhoneGap Build instructions [WinJS][Win10] Fixes "formats" in options passed to BarcodeReader.scan() being ignored (phonegap#524)
|
This thread has been automatically locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables Windows 10 UWP builds to recognize the "formats" options passed to BarcodeReader.scan() to limit the types of codes detected by the underlying ZXing Barcode Reader, which by default tries to detect everything it supports.