Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compress-zstd-1.1.2: the embedded patch fails to apply #132

Closed
chenming1986 opened this issue Mar 9, 2020 · 4 comments
Closed

compress-zstd-1.1.2: the embedded patch fails to apply #132

chenming1986 opened this issue Mar 9, 2020 · 4 comments

Comments

@chenming1986
Copy link
Contributor

The embedded patch "portable-header-prefix.patch" fails to apply during installing compress-zstd-1.1.2. It seems that the line breaks at line 9/11/25/34/43 in the original commit are missing from the final install.sh.

Snippet from build.log:

patching file programs/Makefile
patch: **** malformed patch at line 17: @@ -98,7 +103,7 @@ endif
@chenming1986
Copy link
Contributor Author

Attaching the patch towards pts/compress-zstd-1.1.2
https://gist.github.com/chenming1986/14230227771dd0d070393174043aebbb

@michaellarabel could you please review? Thanks.

@michaellarabel
Copy link
Member

pts/compress-zstd-1.1.3 should now be available with the updated patch. Thanks.

@chenming1986
Copy link
Contributor Author

@michaellarabel thanks for taking care of this, but the patch attached in this issue was supposed to be applied on top of compress-zstd-1.1.2, not to expand in install.sh.
To simplify I created another PR #137 that adds a complete working profile compress-zstd-1.1.4. Please check and sorry for any confusion caused.

@chenming1986
Copy link
Contributor Author

Can we re-open this issue since it still exists as mentioned in the last comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants