Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duotone icons not working on web #20

Closed
k-ane opened this issue Apr 8, 2023 · 5 comments
Closed

Duotone icons not working on web #20

k-ane opened this issue Apr 8, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@k-ane
Copy link

k-ane commented Apr 8, 2023

Testing on web, duotone icons are not showing up, I get this error:
Could not find a set of Noto fonts to display all missing characters. Please add a font asset for the missing characters.

Seemed to work great on MacOS so issue is restricted to web as far as I can tell.

@k-ane
Copy link
Author

k-ane commented Apr 30, 2023

For some added context, the issue only occurs with canvaskit. When using --web-renderer html the duotone icons load fine. May be a Flutter issue not an issue of this package

@rektdeckard rektdeckard added the bug Something isn't working label May 11, 2023
@rektdeckard
Copy link
Member

Hi @k-ane. This appears to be related to this open Flutter bug, in which CanvasKit is unable to render glyphs outside of the BMP (Basic Multilingual Plane) of Unicode. It does not appear to be solved, and the solution everyone seems to take is the same you have said above, using the html renderer.

@rvndsngwn
Copy link


Compiling lib/main.dart for the Web...                          
This application cannot tree shake icons fonts. It has non-constant instances of IconData at the following locations:
  - file:///opt/hostedtoolcache/flutter/3.10.0-stable/x64/.pub-cache/hosted/pub.dev/phosphor_flutter-2.0.0/lib/src/phosphor_icons_regular.dart:8:23
  - file:///opt/hostedtoolcache/flutter/3.10.0-stable/x64/.pub-cache/hosted/pub.dev/phosphor_flutter-2.0.0/lib/src/phosphor_icons_regular.dart:11:29
  ...
  - file:///opt/hostedtoolcache/flutter/3.10.0-stable/x64/.pub-cache/hosted/pub.dev/phosphor_flutter-2.0.0/lib/src/phosphor_icons_duotone.dart:7486:5
Target web_release_bundle failed: Exception: Avoid non-constant invocations of IconData or try to build again with --no-tree-shake-icons.
#0      throwToolExit (package:flutter_tools/src/base/common.dart:10:3)
#1      IconTreeShaker._findConstants (package:flutter_tools/src/build_system/targets/icon_tree_shaker.dart:307:7)
<asynchronous suspension>
#2      IconTreeShaker._getIconData (package:flutter_tools/src/build_system/targets/icon_tree_shaker.dart:108:45)
<asynchronous suspension>
#3      IconTreeShaker.subsetFont (package:flutter_tools/src/build_system/targets/icon_tree_shaker.dart:172:5)
<asynchronous suspension>
#4      copyAssets.<anonymous closure> (package:flutter_tools/src/build_system/targets/assets.dart:127:25)
<asynchronous suspension>
#5      Future.wait.<anonymous closure> (dart:async/future.dart:525:21)
<asynchronous suspension>
#6      copyAssets (package:flutter_tools/src/build_system/targets/assets.dart:105:3)
<asynchronous suspension>
#7      WebReleaseBundle.build (package:flutter_tools/src/build_system/targets/web.dart:385:29)
<asynchronous suspension>
#8      _BuildInstance._invokeInternal (package:flutter_tools/src/build_system/build_system.dart:847:9)
<asynchronous suspension>
#9      Future.wait.<anonymous closure> (dart:async/future.dart:525:21)
<asynchronous suspension>
#10     _BuildInstance.invokeTarget (package:flutter_tools/src/build_system/build_system.dart:785:32)
<asynchronous suspension>
#11     FlutterBuildSystem.build (package:flutter_tools/src/build_system/build_system.dart:614:16)
<asynchronous suspension>
#12     WebBuilder.buildWeb (package:flutter_tools/src/web/compile.dart:81:34)
<asynchronous suspension>
#13     BuildWebCommand.runCommand (package:flutter_tools/src/commands/build_web.dart:191:5)
<asynchronous suspension>
#14     FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:1336:27)
<asynchronous suspension>
#15     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#16     CommandRunner.runCommand (package:args/command_runner.dart:212:13)
<asynchronous suspension>
#17     FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:296:9)
<asynchronous suspension>
#18     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#19     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:244:5)
<asynchronous suspension>
#20     run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:91:9)
<asynchronous suspension>
#21     AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:19)
<asynchronous suspension>
#22     main (package:flutter_tools/executable.dart:91:3)
<asynchronous suspension>

Compiling lib/main.dart for the Web...                             90.2s
Exception: Failed to compile application for the Web.
Error: Process completed with exit code 1.

@h1amza
Copy link

h1amza commented Jul 13, 2023

How to use html renderer and build apk?

@rurickdev
Copy link
Collaborator

This should be fixed with #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants