Skip to content
This repository has been archived by the owner on Nov 6, 2019. It is now read-only.

Add tests for mimedata #96

Merged
merged 2 commits into from
Jun 23, 2016
Merged

Conversation

blink1073
Copy link
Member

--------------------|----------|----------|----------|----------|----------------|
File                |  % Stmts | % Branch |  % Funcs |  % Lines |Uncovered Lines |
--------------------|----------|----------|----------|----------|----------------|
  mimedata.js       |      100 |      100 |      100 |      100 |

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 97.948% when pulling f1be49d on blink1073:mimedata-tests into 95c00bb on phosphorjs:master.

data.setData('baz', { foo: 1, bar: 2 });
expect(data.types()).to.eql(['foo', 'bar', 'baz']);
});

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a test which guarantees types() returns keys in order of calling setData (most recent last).

e.g.

setData('foo', 1)
setData('bar', 2)
setData('baz', 3)
setData('bar', 4)
clearData('foo')
setData('foo', 9)
types() === ['baz', 'bar', 'foo']

@sccolbert
Copy link
Member

lgtm modulo my comment

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 97.948% when pulling 0c08f60 on blink1073:mimedata-tests into 95c00bb on phosphorjs:master.

@sccolbert sccolbert merged commit 14312c3 into phosphorjs:master Jun 23, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants