Fixed errors in documentation for tag creation API

[slavo]

Response format was wrong. Just tried this with the version on openphoto.me and the result is boolean, not a Tag object.

[jmathai]

@slavo thanks for pointing this out. I think this is a bug in the API and it should return the proper response per the documentation. I've opened issue #987 to track it. I believe the solution is in ApiTagController::create

-    return $this->created(sprintf('Tag %s created successfully.', $tag), true);
+    return $this->created(sprintf('Tag %s created successfully.', $tag), $res['result']);

[jmathai]

Upon further investigation we can't return the Tag object because tags with a count of 0 (no photos with that tag) are essentially non-existant. That's why it's returning false. I've added a comment in the code and am merging this.

Thanks!

[slavo]

Great. Now that I think of it, this would however be inconsistent with the APIs for creating other objects (photos). Is that OK?

If tags with a zero count are non-existent, is it then OK to make that count a requirement when creating them? I.e. not being able to create just a tag without any associated photos?

[jmathai]

The photo upload API returns the photo object just created. All create endpoints should return the object created and a 201 response on success. If there are some which do not then definitely open an issue and we'll resolve it.