Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add frame and background selection to the media section #204

Open
Striker62 opened this issue Mar 31, 2024 · 4 comments
Open

add frame and background selection to the media section #204

Striker62 opened this issue Mar 31, 2024 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@Striker62
Copy link

in the media section you have provide the function to add filter to the pictures.

would it be possible to do the same with frames and backgrounds ?

but only if the corresponding function is active in the config.

@mgineer85
Copy link
Collaborator

I consider the frames to be more static. with regards to lower power systems like the pi I try to avoid unnecessary computationally costly operations in postprocessing. So the user shall get the result as fast as possible.

One could precalculate the result one time but to me I think it is out of scope. Still if there is a ready to merge pull request including cache I would accept it.

@Striker62
Copy link
Author

yes you're right the background is too much to render on the liveview.
the more interesing part is the frame

to be a little more flexible i'll rty to setup seperate config files per theme and write a small script to repalce the actual and restart the service.

@Striker62
Copy link
Author

sorry but this request was not for the live view screen it is for the media screen.
but if you have the same concerns also on the media screen it is ok for me.

@mgineer85
Copy link
Collaborator

Ah, I see. You mean in the gallery when you open and image? That could be possible to add later in v2 probably quite easy.
but there is no timeline for this unfortunately.

@mgineer85 mgineer85 added enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants