Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credo and dogma squashed #4

Merged
merged 11 commits into from Feb 1, 2016

Conversation

kbaird
Copy link
Contributor

@kbaird kbaird commented Feb 1, 2016

What's interesting about this is that it reports a Credo error:

$ mix credo
mix.exs:45: warning: function package/0 is unused
Checking 1 source file ...

  Warnings - please take a look                                                                                                                                          
┃ 
┃ [W] ↗ There should be no unused return values for Enum.map().lib/ecto_neo4j.ex:61:15 (Ecto.Neo4j.sort_column)

Please report incorrect results: https://github.com/rrrene/credo/issues

Analysis took 0.1 seconds (0.00s to load, 0.1s running checks)
25 mods/funs, found 1 warning.

Showing priority issues: ↑ ↗ →  (use `--strict` to show all issues, `--help` for options).

Which I believe is a bug in Credo. I've opened rrrene/credo#36 for that.

photomattmills added a commit that referenced this pull request Feb 1, 2016
@photomattmills photomattmills merged commit ceb487d into photomattmills:master Feb 1, 2016
@photomattmills
Copy link
Owner

Awesome.

@kbaird
Copy link
Contributor Author

kbaird commented Feb 1, 2016

Thanks. And Rene agrees that rrrene/credo#36 is legit, so he'll start on that.

@kbaird kbaird deleted the CredoAndDogmaSquashed branch February 1, 2016 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants