Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

page_store: skip compute decline rate of empty page file #233

Merged
merged 1 commit into from
Nov 8, 2022
Merged

page_store: skip compute decline rate of empty page file #233

merged 1 commit into from
Nov 8, 2022

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented Nov 8, 2022

This PR closes #223.

@w41ter w41ter requested a review from zojw November 8, 2022 06:52
@zojw
Copy link
Contributor

zojw commented Nov 8, 2022

ps: how about changing pick_empty_page_files

if file.is_empty() {

to

if file.is_empty() || file.num_active_pages() == 0 {

@w41ter
Copy link
Contributor Author

w41ter commented Nov 8, 2022

@zojw Should these two be equivalent?

@huachaohuang huachaohuang merged commit 6bfd9e9 into photondb:main Nov 8, 2022
@w41ter w41ter deleted the fix_223 branch November 8, 2022 07:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zojw zojw zojw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panicked at 'assertion failed: !score.is_nan()'
3 participants
@w41ter @zojw @huachaohuang