This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
page_store: PageTxn alloc/dealloc pages #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // TODO: ensure that old_addr < new_addr so that we can recover the page table | ||
| // in order. | ||
| todo!() | ||
| assert!(old_addr < new_addr); |
There was a problem hiding this comment.
The caller can not guarantee this condition. We should return Error::Again to let the caller retry instead of panicking here.
There was a problem hiding this comment.
Hmm, the interface doesn't allow us to return an error 🤔
There was a problem hiding this comment.
@huachaohuang Besides this, are there any other questions? Maybe we can merge this first and fix the issue in above later with another PR.
|
Let's merge it and fix the remain problems later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #78, closes #79.