Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change overflows into fees #20

Closed
BlueDragon747 opened this issue Sep 23, 2019 · 2 comments
Closed

Change overflows into fees #20

BlueDragon747 opened this issue Sep 23, 2019 · 2 comments
Assignees
Labels

Comments

@BlueDragon747
Copy link
Collaborator

when using the coincontrol feature it can overflow if the change exceeds 90M in some rare cases
3 times afaik!!

if using that feature select inputs that ~match the amount your sending so change does not overflow until its patched for (limit/fail on overflow rather than sending the tx with excessive fees)

@BlueDragon747 BlueDragon747 self-assigned this Sep 23, 2019
@BlueDragon747 BlueDragon747 changed the title Change overflow into fees Change overflows into fees Sep 24, 2019
@BlueDragon747
Copy link
Collaborator Author

L549 of coincontroldialog.cpp does a check for dust "change < 0.0001 => simply move all change to fees" need to do some testing but think >90M is being returned as too small and then being mistaken for dust and added to fees, going to test/build some changes to this on the weekend

@BlueDragon747
Copy link
Collaborator Author

enforced normal change behavior until the isdust calc fix or unit overflow set by uin64_t?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant