Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop down menus do not disappear. #1181

Closed
JulianEggers opened this issue Apr 8, 2021 · 11 comments
Closed

Drop down menus do not disappear. #1181

JulianEggers opened this issue Apr 8, 2021 · 11 comments
Assignees
Labels
bug Something isn't working released Available in the stable release

Comments

@JulianEggers
Copy link

JulianEggers commented Apr 8, 2021

Drop down menus do not disappear when focusing other elements.
This can result in a UI like this:

Screenshot_20210408-180920.jpg

Chrome on Android with Photoprism opened as Pwa.

I'd suggest to remove the drop down menu whenever the user selects other UI elements.

@kyeb
Copy link

kyeb commented Apr 9, 2021

Looks like this is a bug in Vuetify. This codepen reproduces the problem if you use Chrome mobile (including using the device switcher thingy in Chrome devtools on desktop).

It looks like this is fixed in the latest version of Vuetify, though (see this codepen). I could give upgrading a shot, unless there's a particular reason PhotoPrism is still on Vuetify 1.5?

Edit: looks like upgrading is already being tracked in #886, so I suppose this can just be rolled into that issue.

@graciousgrey graciousgrey added the bug Something isn't working label Apr 11, 2021
@lastzero
Copy link
Member

We use Vuetify 1.5 as upgrading takes a lot of time and there are many other open issues. We don't think this should be the first priority and will do it when we have time. If you sponsor our work, we can eventually hire developers and work faster. Thank you very much! ❤️

@benmccann
Copy link
Contributor

This is also happening with the main nav, which is really driving me crazy. When I click the hamburger menu, the nav opens. However, there is then no way to close the nav. I am forced to navigate to another page

@lastzero
Copy link
Member

Closes when you click on the semi transparent overlay outside the menu (main app area). An edge case might be when the phone screen is so small that only the menu fits on it. Dropdowns close in a similar way and don't stay open for me. Again, there might be edge cases with touching / clicking certain other elements that have custom event handlers.

@benmccann
Copy link
Contributor

That's how I expected it to work, but it's not working for me. I'd installed the PWA for http://demo.photoprism.org/ using Chrome on Android. I'm not sure what the issue is, but it's not due to the presence of other elements because it happens on the video tab where there's only 1 video so the space not covered by the menu is entirely blank

@lastzero
Copy link
Member

I'm mainly using the PWA with Chrome on Android 10. Also tested it on iPhone & iPad. No issues at all. Happy to provide a fix once we figure out why / when this happens. Maybe there's another overlay blocking it?

@lastzero
Copy link
Member

Did you test this using our latest release from April 22nd? Updated a bunch of dependencies.

@lastzero lastzero added the waiting Impediment / blocked / waiting label Apr 25, 2021
@lastzero lastzero self-assigned this Apr 25, 2021
@lastzero
Copy link
Member

lastzero commented May 5, 2021

Is this still happening after upgrading to our latest release? If not, we'd like to close this issue.

@benmccann
Copy link
Contributor

The issue I reported is working now. I'm not sure about the issue that was originally raised here. Sorry if I confused the thread by introducing a new issue.

@kyeb
Copy link

kyeb commented May 6, 2021

The issue as I reproduced it seems to be fixed now as well!

@graciousgrey
Copy link
Member

Thanks for testing :)

@graciousgrey graciousgrey added please-test Ready for acceptance test released Available in the stable release and removed waiting Impediment / blocked / waiting please-test Ready for acceptance test labels May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released Available in the stable release
Projects
Status: Release 🌈
Development

No branches or pull requests

5 participants