Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: File mgmt (archive, delete) from "edit" dialog #3484

Open
stevenroose opened this issue Jun 17, 2023 · 4 comments
Open

Request: File mgmt (archive, delete) from "edit" dialog #3484

stevenroose opened this issue Jun 17, 2023 · 4 comments
Labels
idea Feedback wanted / feature request ux Impacts User Experience

Comments

@stevenroose
Copy link

No matter where, either in "People", "Search", an "Album" view, or "Folders", you can always enter the "edit photo" dialog which has the tabs with the different things to edit. That's great. I would like to request that to this view, some file mgmt options are added. To either delete the file, archive the photo, add it to another album etc. Right now to delete a photo that's either in Search or an album or so, I have to go into "Folders" or "Library" to delete it. Or to archive it from an "Album", I have to go back to "Search".

@stevenroose stevenroose added the idea Feedback wanted / feature request label Jun 17, 2023
@graciousgrey graciousgrey added the ux Impacts User Experience label Jun 19, 2023
@stevenroose
Copy link
Author

Hmm, just came here again to make an issue for that just to find my own issue from last time :) This can't be too hard, right? I usually first upload my photos, then select a while section of them into an album and only then start filtering out some bad ones that are not really focused or something. Right now, I can only "archive" them from the Album view, but in that case they will take up storage still; I'd like to delete them.

@graciousgrey
Copy link
Member

graciousgrey commented Oct 15, 2023

Thank you very much for your feedback!

The option for archiving could be added as a toggle, similar to the options for Private, Scan, and Favorites on the last tab of the edit dialog.

Deleting a photo from the edit dialog would require more logic and consideration. For example, depending on the context from which you opened the edit dialog, we would have to decide which page to automatically open after the file is deleted. Or what happens when a user clicks the back button in the browser.

To edit albums from the edit dialog, we need a new UX element that shows all albums a photo belongs to and allows to remove albums or add new ones. This is planned and we have a separate issue for it.

We also plan to introduce an additional menu that will allow us to make more actions available on all pages. We just haven't had time for it yet.

@hydrandt
Copy link

I would go a step further and add the Archive button to the full screen view (the view you get when you click a thumbnail anywhere). It took me quite some time to realise that when I'm sorting out bad pictures (doing that in the full screen view so I can actually see them) , I have to select them with the selection button, then go back to the list of thumbnails, click the bottom right button, and select Archive there.

I don't know if my workflow is strange, but this is basically the ONLY thing I mostly do with my pics. I don't even need albums, I'm fine with a timeline without the blurry pictures or multiple shots of the same thing. Delete is the main operation I need when managing pictures. And it is so hidden in Photoprism's UI.

If there is an agreement that the top buttons bar in the full screen can swallow one more button, I'm happy to prepare a pull request :)

@graciousgrey
Copy link
Member

@hydrandt Thank you very much for your feedback.

In the long term, we plan to make the actions in full-screen mode customizable, as users prefer different actions and there is not enough space for all of them. However, this is conditioned by the implementation of the new photo viewer.

In the meantime we could consider a PR for the archive action if there is enough space even on small mobile devices. Please note that unfortunately we cannot review, improve and merge pull requests until we are done with our current focus tasks: Open ID Connect and 2FA support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea Feedback wanted / feature request ux Impacts User Experience
Projects
None yet
Development

No branches or pull requests

3 participants