-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow URLs to be bookmarked / shared. Don't lose page when reloading #831
Comments
The viewer just displays search results, as it is implemented right now. So photo 1 doesn't refer to a specific photo, just to the first result. I would expect users to be disappointed if they save or share a link to a photo and then another photo appears (or none, if there are no results this time). Once we have time and a budget, I'm more than willing to give our photo viewer an upgrade. We also need URLs for individual photos to implement link sharing (on our roadmap). |
I think if the photo and video players were both routes instead of dialogs it would allow them to be lazily loaded, which would cut down on the package size a lot (it would also probably allow |
Closed in favor of: #1307 |
If I open up a photo or video the URL is something like https://demo.photoprism.org/photos#&gid=1&pid=1. It'd be nice if the photo ID were in the URL so that if I refreshed the page the same photo would load. E.g. something like https://demo.photoprism.org/photos/2305e512e3b183ec982d60a8b608a8ca501973ba
I'm not that familiar with
vue-router
and whether this would be the best way to implement it, but since the background of the lightbox is opaque you might be able to simply make a new page for the lightbox instead of having it be a modal.The text was updated successfully, but these errors were encountered: