Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read args parm bug or clarification needed #45

Closed
rolanday opened this issue Feb 27, 2019 · 5 comments
Closed

read args parm bug or clarification needed #45

rolanday opened this issue Feb 27, 2019 · 5 comments

Comments

@rolanday
Copy link

Great contribution. Thank you!

AFAICT, should be able to scope query to return tags listed in read args array as shown in following example:

read('./image.jpg', ['-Model', '-Make', ...])

Is this unsupported, bug, or on me?

Thanks again,

-Roland.

@mceachen
Copy link
Member

mceachen commented Feb 27, 2019

Hey @rolanday. Yeah, it's unsupported. Here's the discussion: #44

TL;DR: If you only want Make and Model, you're using the wrong library. There are faster ways to do that.

mceachen added a commit that referenced this issue Feb 27, 2019
@mceachen
Copy link
Member

OK, I thought of a way to do this and not break all the things. Please read the docs carefully before using! https://exiftool-vendored.js.org/classes/exiftool.html#readraw

@rolanday
Copy link
Author

Thanks for the quick replies.

Above snippet was just to illustrate and definitely need a much fuller set of metadata. I'll take a look at your link (thank you!) but this isn't a deal breaker for me either way -- just about perf tuning and wanting to measure impact from reduced set of tags to read.

Thanks again!

-Roland.

@mceachen
Copy link
Member

mceachen commented Feb 27, 2019

Please share any performance numbers (and if you can, the benchmark code and example image inputs). If there's better performance we can wrestle out of this module, I'm all ears.

@rolanday
Copy link
Author

rolanday commented Feb 28, 2019

I will do that. I'm quite pleased the perf relative to the perl implementation of app logic I'm porting to js so can leverage node / electron -- about 2-3x faster thanks to the parallelism and not reloading ExifTool. You did your homework!

Thanks again :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants