Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Matthew,
So I've added struct support. Turns out we didn't need to do any major change to the way we read from Exiftool, just adding the
-struct
argument seemed to do the trick.There's a couple of things to bear in mind:
Tags.ts
to include a struct type definition for the one I was interested in. I'm not sure how to go about having this automatically parsed like you do inmktags
, perhaps you could shed some light on that? I'm not sure how often you regenerate that file, is putting it in manually an option for now?Let me know if there's any problems with this or if I've done some bad Typescript again!