Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Struct Support #43

Closed
wants to merge 5 commits into from
Closed

Added Struct Support #43

wants to merge 5 commits into from

Conversation

Circuit8
Copy link
Contributor

Hey Matthew,

So I've added struct support. Turns out we didn't need to do any major change to the way we read from Exiftool, just adding the -struct argument seemed to do the trick.

There's a couple of things to bear in mind:

  1. I manually updated Tags.ts to include a struct type definition for the one I was interested in. I'm not sure how to go about having this automatically parsed like you do in mktags, perhaps you could shed some light on that? I'm not sure how often you regenerate that file, is putting it in manually an option for now?
  2. Currently the struct writing is a basic implementation that only writes strings, one level deep. From what I can tell this will cover the majority of use cases, but from what I understand Exiftool actually supports deeply nested structs, so might be something we could think about supporting in the future.

Let me know if there's any problems with this or if I've done some bad Typescript again!

@Circuit8 Circuit8 mentioned this pull request Jan 24, 2019
@mceachen
Copy link
Member

Wow, I think all 17 of codeclimate's errors were bogus, and I turned off codacy as well

src/WriteTask.ts Outdated Show resolved Hide resolved
src/WriteTask.spec.ts Outdated Show resolved Hide resolved
@Circuit8
Copy link
Contributor Author

Cool I've made those changes let me know what you think

@mceachen
Copy link
Member

The windows CI builds are being flaky. I kicked off a rebuild of your commit.

@mceachen
Copy link
Member

Thanks for the PR! Your code is now in v8.0.0.

@mceachen mceachen closed this Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants