Ignore media files #221
Merged
Ignore media files #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added feature to ignore specific media files. E.g. to ignore .png media files, add '*.png' to .photoviewignore file or add 'img_1234.jpg' to ignore a specific file. This applies to the current dir and any potential subdir. Matching is case sensitive. File ignore pattern must include a '.', otherwise the pattern is treated as a dir ignore pattern. Signed-off-by: Kjeldgaard <Kjeldgaard@users.noreply.github.com>
|
First attempt at a media file ignore feature. Comments are welcome. |
viktorstrate
requested changes
Feb 27, 2021
There was a problem hiding this comment.
Hi @Kjeldgaard thank you for the pull-request. I've added some comments. I'd like to hear what you think as well. Please feel free to reply to them if you think I've missed something or it's unclear.
Store album ignore data in cache and not database. Fix albums with only ignore-media-only not to be shown in album list. Use github.com/sabhiram/go-gitignore exclusively for photoviewignore. Signed-off-by: Kjeldgaard <Kjeldgaard@users.noreply.github.com>
|
Ok, so I'm now using cache for storing ignore data. And I'm not using path/filepath for any file matching anymore. I had an issue with albums showing up, despite the album only contained files which should be ignored. It required me to change directoryContainsPhotos(), but now it passes my own tests. |
|
Looks great, I'll test it my self in one of the following days 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added feature to ignore specific media files. E.g. to ignore .png media
files, add '*.png' to .photoviewignore file or add 'img_1234.jpg' to
ignore a specific file. This applies to the current dir and any
potential subdir. Matching is case sensitive. File ignore pattern must
include a '.', otherwise the pattern is treated as a dir ignore pattern.
Signed-off-by: Kjeldgaard Kjeldgaard@users.noreply.github.com