Add german translation #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hmm, I've not noticed that before. It should be automatically fixed by prettier in the pre-commit hook though. Looks good, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
first of all, a huge Thanks for this project, it fits perfectly for my personal media collection, I absolutely love it!
After seeing the localization options, I added a German translation and generated the needed files. It would be great, if the PR gets accepted.
After all, I have a question about the code generation:
I tried automatically generating the ui code with
npm run genSchemaTypes, but this changed all occurrences of single quotes to double quotes in all generated files. I needed to revert everything and make the needed change manually. Did I make something wrong or is there a setting to generate the correct code in favor of the existing code?