update Kagami/go-face target commit and new deps for it #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #389 +/- ##
=======================================
Coverage 42.37% 42.37%
=======================================
Files 86 86
Lines 3212 3212
Branches 348 348
=======================================
Hits 1361 1361
Misses 1734 1734
Partials 117 117
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Thank you for the update. A link to the original patch Kagami/go-face#72 for future reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-face only linked blas, which caused issues on systems that don't bundle cblas with blas in the distribution repositories (e.g. Arch Linux). It was updated to explicitly link cblas. This requires Ubuntu systems (and similar distributions) to explicitly install cblas so the new linking doesn't fail.
libatlas-base-devis one way to solve this (and I tested it). OpenBLAS may also satisfy it, but I have not tested that.Referencing the newer go-face commit allows systems such as Arch Linux to install photoview.