Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix periodic scanner form #483

Merged
merged 1 commit into from Aug 30, 2021
Merged

Fix periodic scanner form #483

merged 1 commit into from Aug 30, 2021

Conversation

viktorstrate
Copy link
Member

No description provided.

@viktorstrate viktorstrate linked an issue Aug 30, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #483 (3caa3da) into master (d92747c) will increase coverage by 2.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #483      +/-   ##
==========================================
+ Coverage   34.44%   36.50%   +2.06%     
==========================================
  Files         130      130              
  Lines        4091     4095       +4     
  Branches      539      539              
==========================================
+ Hits         1409     1495      +86     
+ Misses       2558     2476      -82     
  Partials      124      124              
Flag Coverage Δ
api 33.81% <ø> (ø)
ui 38.50% <100.00%> (+3.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ui/src/Pages/SettingsPage/SettingsPage.tsx 36.36% <ø> (+36.36%) ⬆️
ui/src/Pages/SettingsPage/PeriodicScanner.tsx 96.07% <100.00%> (+96.07%) ⬆️
ui/src/Pages/SettingsPage/Users/ViewUserRow.tsx 4.76% <0.00%> (+4.76%) ⬆️
ui/src/Pages/SettingsPage/Users/EditUserRow.tsx 8.33% <0.00%> (+8.33%) ⬆️
ui/src/Pages/SettingsPage/Users/UsersTable.tsx 12.50% <0.00%> (+12.50%) ⬆️
...rc/Pages/SettingsPage/ScannerConcurrentWorkers.tsx 14.28% <0.00%> (+14.28%) ⬆️
...rc/Pages/SettingsPage/Users/UserChangePassword.tsx 15.38% <0.00%> (+15.38%) ⬆️
ui/src/Pages/SettingsPage/Users/UserRow.tsx 19.04% <0.00%> (+19.04%) ⬆️
.../Pages/SettingsPage/Users/EditUserRowRootPaths.tsx 21.05% <0.00%> (+21.05%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d92747c...3caa3da. Read the comment docs.

@viktorstrate viktorstrate merged commit 293ac99 into master Aug 30, 2021
@viktorstrate viktorstrate deleted the fix-468 branch August 30, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to save periodic scan setting
1 participant