Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Following breadcrumbs now closes sidebar #707

Merged
merged 1 commit into from Jun 30, 2022
Merged

Following breadcrumbs now closes sidebar #707

merged 1 commit into from Jun 30, 2022

Conversation

nathanrdodson
Copy link
Contributor

Fixes #657

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #707 (29516a3) into master (8d78c58) will increase coverage by 0.00%.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##           master     #707   +/-   ##
=======================================
  Coverage   42.63%   42.63%           
=======================================
  Files         146      146           
  Lines        4771     4773    +2     
  Branches      633      649   +16     
=======================================
+ Hits         2034     2035    +1     
  Misses       2545     2545           
- Partials      192      193    +1     
Flag Coverage Δ
api 37.43% <ø> (ø)
ui 46.90% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/components/sidebar/MediaSidebar/MediaSidebar.tsx 83.33% <50.00%> (-1.45%) ⬇️
ui/src/apolloClient.ts 28.30% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d78c58...29516a3. Read the comment docs.

@viktorstrate viktorstrate merged commit 548eeed into photoview:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Side info should close when clicking on a person or album link
2 participants