Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend notification improvements #965

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

kkovaletp
Copy link
Contributor

@kkovaletp kkovaletp commented Jun 8, 2024

Fixes #924.

Auto-calculate the container's height (up to 5 lines); wrap text inside the container and show a vertical scrollbar if needed; set a different color for the background of errors and success messages.

This is how it looks now with the fix on Mac in Firefox:
Снимок экрана 11 06 2024 в 13 49 00

…e container and show a vertical scrollbar if needed
@kkovaletp kkovaletp added bug Something isn't working good first issue Good for newcomers UI Related to the frontend web ui written in Javascript high priority javascript Pull requests that update Javascript code labels Jun 8, 2024
@kkovaletp kkovaletp requested a review from jordy2254 June 8, 2024 15:41
@kkovaletp kkovaletp self-assigned this Jun 8, 2024
@kkovaletp kkovaletp added this to In progress in Roadmap via automation Jun 8, 2024
@kkovaletp kkovaletp moved this from In progress to Before next release in Roadmap Jun 8, 2024
@kkovaletp kkovaletp moved this from In progress to Before next release in Roadmap Jun 8, 2024
ui/testing/setupTests.ts Fixed Show fixed Hide fixed
ui/testing/setupTests.ts Fixed Show fixed Hide fixed
ui/testing/setupTests.ts Fixed Show fixed Hide fixed
ui/testing/setupTests.ts Fixed Show fixed Hide fixed
ui/testing/setupTests.ts Fixed Show fixed Hide fixed
ui/testing/setupTests.ts Fixed Show fixed Hide fixed
ui/testing/setupTests.ts Fixed Show fixed Hide fixed
ui/testing/setupTests.ts Fixed Show fixed Hide fixed
ui/testing/setupTests.ts Fixed Show fixed Hide fixed
ui/testing/setupTests.ts Fixed Show fixed Hide fixed
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.97%. Comparing base (4133694) to head (b463118).
Report is 6 commits behind head on master.

Current head b463118 differs from pull request most recent head 0713c97

Please upload reports for the commit 0713c97 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #965       +/-   ##
===========================================
- Coverage   56.43%   24.97%   -31.46%     
===========================================
  Files         196       96      -100     
  Lines       15601     4408    -11193     
  Branches      558        0      -558     
===========================================
- Hits         8804     1101     -7703     
+ Misses       6543     3053     -3490     
  Partials      254      254               
Flag Coverage Δ
api 24.97% <ø> (+0.03%) ⬆️
ui ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kkovaletp kkovaletp added the help wanted Extra attention is needed label Jun 11, 2024
@kkovaletp
Copy link
Contributor Author

I've tried to write the unit test to cover my changes and the messages component in general, but stuck with failed tests and don't know how to fix the issue((
So, I'd appreciate your help if you know what is the root cause of the failure and how to fix it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed high priority javascript Pull requests that update Javascript code UI Related to the frontend web ui written in Javascript
Projects
Roadmap
Before next release
Development

Successfully merging this pull request may close these issues.

Frontend notification improvements
1 participant