-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend notification improvements #965
base: master
Are you sure you want to change the base?
Conversation
…e container and show a vertical scrollbar if needed
728a562
to
7d69e88
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #965 +/- ##
===========================================
- Coverage 56.43% 24.97% -31.46%
===========================================
Files 196 96 -100
Lines 15601 4408 -11193
Branches 558 0 -558
===========================================
- Hits 8804 1101 -7703
+ Misses 6543 3053 -3490
Partials 254 254
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
94f7e22
to
b463118
Compare
I've tried to write the unit test to cover my changes and the |
Fixes #924.
Auto-calculate the container's height (up to 5 lines); wrap text inside the container and show a vertical scrollbar if needed; set a different color for the background of errors and success messages.
This is how it looks now with the fix on Mac in Firefox:
![Снимок экрана 11 06 2024 в 13 49 00](https://private-user-images.githubusercontent.com/32730812/338558311-21b62f58-2585-41e0-8912-e42351f9ab86.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAyNTI5NzksIm5iZiI6MTcyMDI1MjY3OSwicGF0aCI6Ii8zMjczMDgxMi8zMzg1NTgzMTEtMjFiNjJmNTgtMjU4NS00MWUwLTg5MTItZTQyMzUxZjlhYjg2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA2VDA3NTc1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ0MzIzNDNkOGUyMzhiMzliZDRhMWEzMDQyZGFiMTkzZmE3MjRlY2RlZjg0YzhkZGQxNWZhYTVkMDJmMTRlMWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.thXDmf2-cpcS97CDz2bzaca8dqCjM-G-GvK9mdcS8LY)