Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and impose some code standard #21

Closed
danielhollas opened this issue Jun 4, 2018 · 4 comments · Fixed by #64
Closed

Create and impose some code standard #21

danielhollas opened this issue Jun 4, 2018 · 4 comments · Fixed by #64
Assignees
Milestone

Comments

@danielhollas
Copy link
Contributor

danielhollas commented Jun 4, 2018

We should make at least some basic rules and try to stick to them.

For white-space, we could use e.g. this:
https://github.com/pseewald/fprettify

See also: http://fortranwiki.org/fortran/show/Tools

@danielhollas
Copy link
Contributor Author

We should do this as the last commit of 2.1 release and AFTER merging all current branches.

@danielhollas danielhollas self-assigned this Jun 20, 2018
@danielhollas
Copy link
Contributor Author

Here's a neat trick for ignoring huge formatting commits in git-blame

https://www.moxio.com/blog/43/ignoring-bulk-change-commits-with-git-blame

And here's one example from Discourse
https://github.com/discourse/discourse/blob/c61ebc9ba67d6588c09c2b93205865e0fd388f51/.git-blame-ignore-revs

danielhollas added a commit that referenced this issue Oct 1, 2020
After cloning the ABIN repo, you should run

$ ./setup_dev_environment.sh

to install hooks, fprettify and vim settings.

Step towards #21.
@danielhollas danielhollas added this to the Version 1.2 milestone Oct 7, 2020
@danielhollas
Copy link
Contributor Author

We will use fprettify for this, though it's capabilities are fairly limited. We should also add fprettify workflow to CI.

We should also be using -Wall compiler option and use GFortran as the de-facto linter.

@danielhollas
Copy link
Contributor Author

There have been a new release of fprettify, which is very encouraging! Some of the new functionality will likely be very useful.

https://github.com/pseewald/fprettify/releases/tag/v0.3.7

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant