Dialog: allow custom CSS classes + add getter for header #76

lehnerchristian · 2019-10-30T09:27:46Z

Closes #75

this is a minor change and should not be breaking

…er of the dialog

…n they're added

thinkh

Please have a look at my refactoring suggestion.

src/dialogs.ts

thinkh

Thanks for the refactoring. It looks good now. Just a question out of curiosity.

src/dialogs.ts

added the possibility of custom CSS classes and a getter for the head…

f4f722a

…er of the dialog

lehnerchristian requested a review from thinkh October 30, 2019 09:27

lehnerchristian assigned thinkh Oct 30, 2019

lehnerchristian mentioned this pull request Oct 30, 2019

Allow custom CSS classes in showProveanceGraphNotFoundDialog datavisyn/tdp_core#238

Merged

Christian Lehner added 2 commits October 30, 2019 10:32

Merge branch 'develop' into clehner/75_extensible_dialog

379932a

use a typecast instead of a generic parameter

7c1857d

lehnerchristian added the type: feature New feature or request label Oct 30, 2019

select button with specific CSS class to not select other buttons whe…

d03196d

…n they're added

thinkh changed the title ~~added the possibility of custom CSS classes and a getter for the head…~~ Dialog: allow custom CSS classes + add getter for header Oct 31, 2019

thinkh suggested changes Oct 31, 2019

View reviewed changes

src/dialogs.ts Outdated Show resolved Hide resolved

extracted common interface

d21fdf4

thinkh approved these changes Nov 4, 2019

View reviewed changes

src/dialogs.ts Show resolved Hide resolved

puehringer approved these changes Nov 5, 2019

View reviewed changes

thinkh merged commit f2f4bf7 into develop Nov 12, 2019

thinkh deleted the clehner/75_extensible_dialog branch November 12, 2019 10:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dialog: allow custom CSS classes + add getter for header #76

Dialog: allow custom CSS classes + add getter for header #76

lehnerchristian commented Oct 30, 2019 •

edited by thinkh

Loading

thinkh left a comment

thinkh left a comment

Dialog: allow custom CSS classes + add getter for header #76

Dialog: allow custom CSS classes + add getter for header #76

Conversation

lehnerchristian commented Oct 30, 2019 • edited by thinkh Loading

thinkh left a comment

Choose a reason for hiding this comment

thinkh left a comment

Choose a reason for hiding this comment

lehnerchristian commented Oct 30, 2019 •

edited by thinkh

Loading