Proper caching

[szepeviktor]

Please do not encourage users to cache vendor directory.

path: vendor/

It makes CI unpredictable.

BTW ::set-output is unused in README.

[g105b]

Hi @szepeviktor ,

I considered the caching of the vendor directory a useful feature (as long as the cache is validated against the composer.lock file). Please can you suggest an alternative method of doing this?

The documentation of https://github.com/actions/cache was used when forming my opinion of caching the vendor directory (the example uses the node_modules directory of an NPM project instead.

[szepeviktor]

I'm not able to convince you that only the cache directory should be actually cached.
travis-ci/travis-ci#4579 (comment)

Composer can install packages from the cache to /vendor directory in 1 second!
In theory it applies also for npm, in reality npm is viktor-blacklisted, please consider using Yarn v1/v2.

[szepeviktor]

Please can you suggest an alternative method of doing this?

Please see this PR #26

[g105b]

This is great, thanks very much. I'll check it out and merge the PR once tested.

[g105b]

Thanks. Merged #26.

[szepeviktor]

You're welcome.