remove unused logic #106
Merged
remove unused logic #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
============================================
+ Coverage 99.70% 99.82% +0.12%
+ Complexity 938 936 -2
============================================
Files 34 34
Lines 2345 2341 -4
============================================
- Hits 2338 2337 -1
+ Misses 7 4 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the intent here is correct; if you pass in an empty array, then it should equate to checking for
null, but as far as I can tell this logic has always been unreachable, because we currently throw an exception if the number of vars doesn't match the number of?tokens. Can revisit someday.