New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New release with PHP 8 support? #386
Comments
I would rather think even a beta release would be okay till the maintainers consider it's ready for a stable release. |
Yeah that's totally fine too, I don't expect it to be finished. A tagged beta/RC release, published to PECL, makes it easier for a broader audience to test it and report (and fix!) issues. |
(I was going by the status tracked at https://blog.remirepo.net/post/2020/09/21/PHP-extensions-status-with-upcoming-PHP-8.0 in my assertion that Git master is in a working state, FWIW) |
What is the status of PHP8 support? I tried manually installing it, but when running checking for amqp using pkg-config... configure: error: librabbitmq not found I'm on MacOS 10.15.7, running PHP 8. I installed the EDITThis did the trick: https://gist.github.com/wcomnisky/6d276a9894a5b2078b552cc492fa1abd |
It would be nice to have a release which compiles with php 8 |
As far as I can tell, the https://travis-ci.com/github/travis-ci/php-src-builder/jobs/452193258#L5526 There is also #383. |
Ok, thanks. That would be good enough for a first try. But for packaging a released version would be much better, even if it has many warnings during compile. |
How to compile AMQP extension for PHP 8.0 via Multistage Dockerfile |
This did not work for me as it was, but it did work after I switched from UPD: That branch is merged so now I'm building from the official repo. |
Will roll a beta release in the next couple of days for everybody to test. Looking forward to your feedback! |
We look forward to seeing AMQP on PHP8. |
Thanks for this! I just had to add the rabbitmq-c library to the final image: |
Adding my subscription to this topic. This solution worked for me. Hopefully this will get released soon. I'm a little surprised some of these libraries weren't already made 8 compatible before it's release. |
Not the first or last time this has happened, right now just compiling extension from git master branch in our Dockerfile |
The same for my widely used script that installs PHP extensions in docker PHP containers: mlocati/docker-php-extension-installer#233 |
@lstrojny friendly ping, we need this release <3 |
@michaljusiega you can easily install amqp with PHP 8.0 by using the master branch of this project: curl -sSLf https://codeload.github.com/php-amqp/php-amqp/tar.gz/df1241852b359cf12c346beaa68de202257efdf1 | tar xz
cd php-amqp-df1241852b359cf12c346beaa68de202257efdf1
phpize
./configure
make -j$(nproc)
make install
cd ..
rm -rf php-amqp-df1241852b359cf12c346beaa68de202257efdf1 (and if you use Docker you can use my |
Roughly following advice from @insekticid & @mlocati, I was able to add the
You can also clean up the image a bit by deleting the PHP source after compiling:
|
I think part of the community of PHP don't want to do workaround using your suggestions. |
I think Heroku is also waiting for a release. |
Please create a new release, I guess it will be 1.11.0 |
I wonder as well as @michaljusiega. How hard is it to release a version @lstrojny? |
Folks, as much as I'm looking forward for a new release as you are, please remember that this is an open source project and not a full time job. I'm fairly sure that the radio silence on @lstrojny's end isn't on purpose. |
You are both right, but if you manage a PHP project, you also have to take responsibility? |
Yeah, this situation is not quite a good one. PHP 8 was announced ~ 1 year ago. So changes could have been made here as they were on other projects. For the developer this should be a simple s&r to get it right to the latest api changes. Not much fuss about it. It is really annoying many pecl-packages still don't have php 8 versions. |
there are no links for windows and php 8.0 :( |
See #390. |
PR: #396 |
See #396 (comment) |
@lstrojny sorry for asking again, but do you have any ETA on when the stable release will be released? I know that the beta is on PECL, but as you can imagine I don't feel comfortable using it in production and we're almost half a year after the release of PHP8 |
@ste93cry If that helps, we've been using I would love to see a final release too, though. |
And compiled Windows versions with PR #396 can be found at A phpinfo() dump for instance: |
@Jan-E I am unable to find compiled Windows version for PHP 8 in your provided link. Could you please provide direct link? |
There are no direct links. A php_amqp.dll can be found in each zip-file on https://www.apachelounge.com/viewtopic.php?t=6359 |
You will need the rabbitmq.4.dll in the zip as well. |
Ehy @lstrojny , What's the blocker? Full support for Windows? Can we help in any way? |
FTR, we are using PHP 8 + php-amqp for many month now. And we don't have any issue. |
Same here, we've been using 1.11.0beta in production on PHP 8 and don't have encountered any issues 😊 |
Full Windows support should not be a blocker. With #396 Windows support is OK in PHP 8.0. And in PHP 8.1.0 beta 3 as well. See https://www.apachelounge.com/viewtopic.php?p=30903 if you want to test this on Windows. Or https://ci.appveyor.com/project/Jan-E/php-amqp/builds/40429159 if you want to see how Appveyor builds the DLL's. Look in the artifacts tab of each job to download the results. |
Hello, thank you for the link. I tried to add the I don't understand why, my |
The PHP downloads from windows.php.net contain a file deplister.exe. Run that on the DLL: |
LOL PHP 8.1 was released a few days ago... :D Should we change to also include the 8.1 version? :D |
See #399, PHP8.1 support is in development apparently, although the last activity in the experimental PR is a month ago 😕 |
Version 1.11.0 has been released and it supports both PHP 8.0 and 8.1 |
NICE! |
@lstrojny Thank you so much! 👏 |
awesome, thank you very much. |
Hi @lstrojny and others,
PHP 8.0.0 is getting really close and it looks like this extension supports it already.
All that's missing is a Git tag, and a release to PECL :)
Would be super if that could be done anytime soon so that e.g. PaaSes have a stable release version to provide to customers.
Thanks!
The text was updated successfully, but these errors were encountered: