Allow overriding declare for queues and exchanges. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
@pdezwart ping |
|
I we the activity! I'm ju swamped :) who wants perms to make changes? On Tuesday, October 2, 2012, Lars Strojny wrote:
|
|
I would like to help. |
|
Would also accept perms. But I do promise to create pullreqs for you guys to review, until I feel more confident. I'm also fine with only Lars getting added, though. He seems to be quite responsive :-) |
pdezwart
added a commit
that referenced
this pull request
Oct 2, 2012
Allow overriding declare for queues and exchanges.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch renames AMQPExchange::declare() to AMQPExchange::declareExchange() and AMQPQueue::declare() to AMQPQueue::declareQueue() to make it possible to override this in derived Classes (essential for mocking these classes for unittesting without a broker).
It also introduces two aliases ::declare() to provide backwards compability.