Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change base namespace to PhpAmqpLib #332

Closed
postalservice14 opened this issue Feb 11, 2016 · 6 comments
Closed

Change base namespace to PhpAmqpLib #332

postalservice14 opened this issue Feb 11, 2016 · 6 comments

Comments

@postalservice14
Copy link

Now that the RabbitMqBundle is a part of the php-amqplib organization, it might be good to change the base namespace from OldSound to PhpAmqpLib. The problem is that this would be a BC break, so you would have to make that happen during the next major release. But just wanted to start the discussion here...

@stloyd
Copy link
Collaborator

stloyd commented Feb 11, 2016

This would be really big BC break, TBH. I'm not sure it's worth it... at least for now.

IMO would be better to get "everything" fixed/merged that is waiting etc. and then think after that about such moves.

Just my 2 cents ;)

@postalservice14
Copy link
Author

@stloyd Yeah, that is true. It's fine if it's not something to do now, just something to throw in the backlog.

@JarJak
Copy link

JarJak commented Mar 2, 2016

👍 for doing this in next major release (2.0)

@postalservice14 postalservice14 added this to the 2.x.x milestone Mar 2, 2016
@perajovic
Copy link

Also we can manage some migration script as well.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@ramunasd
Copy link
Member

It would be very big and breaking change. Not planned any time soon AFAIK.

@ramunasd ramunasd removed this from the 2.x.x milestone Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants