Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7 support #440

Closed
gephaest opened this issue Sep 27, 2016 · 5 comments
Closed

PHP 7 support #440

gephaest opened this issue Sep 27, 2016 · 5 comments

Comments

@gephaest
Copy link

Is php-amqplibsupports PHP 7? I checked lib by sstalle/php7cc package and found some warnings:

➜  bin git:(master) ✗ ./php7cc /path/to/project/vendor/php-amqplib

File: /path/to/project/vendor/php-amqplib/php-amqplib/PhpAmqpLib/Wire/AMQPReader.php
> Line 302: Bitwise shift by 32 bits
$hi \ 32;
> Line 315: Bitwise shift by 32 bits
$hi \ 32;


File: /path/to/project/vendor/php-amqplib/php-amqplib/PhpAmqpLib/Wire/AMQPWriter.php
> Line 333: Bitwise shift by 32 bits
$n >> 32;

Checked 48 files in 1.901 seconds
@Nyholm
Copy link
Contributor

Nyholm commented Sep 29, 2016

Im running it on php 7.0.

@sobstel
Copy link

sobstel commented Oct 5, 2016

It works ok at PHP 7.0.11 for me.

@Nyholm
Copy link
Contributor

Nyholm commented Oct 6, 2016

@gephaest,would you mind provide a PR with a failing unit test?

@mente
Copy link
Contributor

mente commented Nov 8, 2016

Looking at sstalle/php7cc#77 seems like php7cc had a "bug".

@hairyhum
Copy link
Collaborator

Addressed in sstalle/php7cc#77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants