Define default ssl context parameter #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1060 +/- ##
============================================
- Coverage 73.42% 73.05% -0.37%
+ Complexity 1009 1007 -2
============================================
Files 37 37
Lines 3055 3069 +14
============================================
- Hits 2243 2242 -1
- Misses 812 827 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lukebakken
approved these changes
Jan 13, 2023
lukebakken
force-pushed
the
fix_ssl_connection_default_params
branch
from
ac26c18
to
26b4c34
Compare
|
Thanks @ramunasd |
lukebakken
added a commit
that referenced
this pull request
Jan 18, 2023
lukebakken
added a commit
that referenced
this pull request
Jan 18, 2023
lukebakken
added a commit
that referenced
this pull request
Jan 18, 2023
lukebakken
added a commit
that referenced
this pull request
Jan 18, 2023
lukebakken
added a commit
that referenced
this pull request
Jan 18, 2023
lukebakken
added a commit
that referenced
this pull request
Jan 20, 2023
lukebakken
added a commit
that referenced
this pull request
Jan 20, 2023
Fixes #1065 Add deprecation error Add non-TLS SSL test Only trigger_error in version 8 and higher do not report user deprecations as errors in phpunit Update PhpAmqpLib/Connection/AMQPSSLConnection.php Co-authored-by: Andrii Dembitskyi <andrew.dembitskiy@gmail.com> Co-authored-by: Andrii Dembitskyi <andrew.dembitskiy@gmail.com>
kratkyzobak
pushed a commit
to kratkyzobak/php-amqplib
that referenced
this pull request
Feb 9, 2024
…on_default_params Define default ssl context parameter
kratkyzobak
pushed a commit
to kratkyzobak/php-amqplib
that referenced
this pull request
Feb 9, 2024
Fixes php-amqplib#1065 Add deprecation error Add non-TLS SSL test Only trigger_error in version 8 and higher do not report user deprecations as errors in phpunit Update PhpAmqpLib/Connection/AMQPSSLConnection.php Co-authored-by: Andrii Dembitskyi <andrew.dembitskiy@gmail.com> Co-authored-by: Andrii Dembitskyi <andrew.dembitskiy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1013
Follow up forgotten promise 🤔
#674 (comment)