fix regression after #675 due to too early changed flag #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fastest fix ever! |
lukebakken
approved these changes
Apr 5, 2019
kratkyzobak
pushed a commit
to kratkyzobak/php-amqplib
that referenced
this pull request
Feb 9, 2024
…_regresion_675 fix regression after php-amqplib#675 due to too early changed flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #675 introduced issue with connection close because AbstractConnection->close() sets flag too early, right before check:
So everything else after this check became dead code. Besides fix for this issue I added "hard" close on any exception during closing process.