Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phpunit tests reported as risked #755

Merged
merged 2 commits into from Nov 15, 2019

Conversation

ramunasd
Copy link
Member

  • some tests does not have any asserts and gets reported by phpunit
  • exclude more incompatible tests for travis and appveyor
  • report all errors types during tests, including notices and deprecations
  • perform code coverage only once per build
  • other minor improvements and style fixes

@ramunasd ramunasd added this to the 2.11.0 milestone Nov 15, 2019
Copy link
Collaborator

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, have a great weekend

@lukebakken lukebakken merged commit 993c30f into php-amqplib:master Nov 15, 2019
@ramunasd ramunasd deleted the fix_risky_tests branch November 16, 2019 15:03
kratkyzobak pushed a commit to kratkyzobak/php-amqplib that referenced this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants