Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change phpDocumentator template, fix incorrect constructor documentation #771

Merged
merged 2 commits into from Jan 8, 2020
Merged

change phpDocumentator template, fix incorrect constructor documentation #771

merged 2 commits into from Jan 8, 2020

Conversation

ramunasd
Copy link
Member

@ramunasd ramunasd commented Jan 2, 2020

Change phpDocumentator template and fix #769

@ramunasd ramunasd added the bug label Jan 2, 2020
@ramunasd ramunasd added this to the 2.11.1 milestone Jan 2, 2020
lukebakken added a commit that referenced this pull request Jan 2, 2020
@lukebakken
Testing #771
ebbe24c
lukebakken added a commit that referenced this pull request Jan 2, 2020
@lukebakken
Testing #771
7fc3493
lukebakken
lukebakken requested changes Jan 2, 2020
View reviewed changes
Copy link
Collaborator

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built the docs and pushed the gh-pages branch, but the same count() error persists. Do you not see that error?

https://php-amqplib.github.io/php-amqplib/classes/PhpAmqpLib.Message.AMQPMessage.html#method___construct

I'm using PHP 7.4 on FreeBSD

@ramunasd
Copy link
Member Author

ramunasd commented Jan 2, 2020 •
edited

Since PHP7.2 a warning is emitted when trying to count non countable variables. Looks like older twig versions aren't compatible.
I disabled error reporting.

lukebakken added a commit that referenced this pull request Jan 7, 2020
@lukebakken
Testing #771
a539782
@lukebakken
Copy link
Collaborator

@ramunasd ... unfortunately it's still not working -

https://php-amqplib.github.io/php-amqplib/classes/PhpAmqpLib.Message.AMQPMessage.html#method___construct

Should I be using a different version of PHP? Here is what I'm using:

$ php --version
PHP 7.4.1 (cli) (built: Dec 24 2019 01:19:59) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies

@ramunasd
Copy link
Member Author

ramunasd commented Jan 7, 2020

I'm sorry, my bad. Should be 0 as error reporting rather than -1(all errors) 🤦‍♂

lukebakken added a commit that referenced this pull request Jan 8, 2020
@lukebakken
Testing #771
bb02ecb
lukebakken
lukebakken approved these changes Jan 8, 2020
View reviewed changes
Copy link
Collaborator

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramunasd works great! Thanks

@lukebakken lukebakken merged commit 8614c1f into php-amqplib:master Jan 8, 2020
@ramunasd ramunasd deleted the phpdocumentator_template branch January 8, 2020 07:42
kratkyzobak pushed a commit to kratkyzobak/php-amqplib that referenced this pull request Feb 9, 2024
@lukebakken
Merge pull request php-amqplib#771 from ramunasd/phpdocumentator_temp…
23b72e2 
…late

change phpDocumentator template, fix incorrect constructor documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukebakken lukebakken lukebakken approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.11.1
Development

Successfully merging this pull request may close these issues.

Incorrect documentation for AMQPMessage constructor (and others)
2 participants
@ramunasd @lukebakken