feat: add priority support #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1223880493
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1234529942
💛 - Coveralls |
leeqvip
requested changes
Sep 12, 2021
| foreach ($this->items['p'] as $ptype => $assertion) { | ||
| if ($assertion->tokens[0] != sprintf("%s_priority", $ptype)) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
@basakest The first column is not necessarily the priority column, I think array_search($assertion->tokens, sprintf("%s_priority", $ptype)) can be used here .
leeqvip
requested changes
Sep 14, 2021
| }); | ||
| foreach ($assertion->policy as $i => $policy) { | ||
| $assertion->policyMap[implode(',', $policy)] = $i; | ||
| } |
There was a problem hiding this comment.
@basakest Here to be sorted according to the specified priority column, the following addPolicy should also be like this .
feat: add priority support feat: add priority support
leeqvip
approved these changes
Sep 15, 2021
|
🎉 This PR is included in version 3.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.