Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement updatePolicies, fix #88 #91

Merged
merged 1 commit into from Jul 25, 2021
Merged

feat: implement updatePolicies, fix #88 #91

merged 1 commit into from Jul 25, 2021

Conversation

basakest
Copy link
Contributor

fix #88

@hsluoyz hsluoyz requested a review from leeqvip July 23, 2021 08:34
@leeqvip
Copy link
Member

leeqvip commented Jul 23, 2021

@basakest Some checks were not successful, please fix.

@coveralls
Copy link

coveralls commented Jul 23, 2021

Pull Request Test Coverage Report for Build 1064070255

  • 38 of 40 (95.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 92.097%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/InternalEnforcer.php 15 17 88.24%
Totals Coverage Status
Change from base Build 1048376777: 0.3%
Covered Lines: 1107
Relevant Lines: 1202

💛 - Coveralls

@leeqvip
Copy link
Member

leeqvip commented Jul 23, 2021

@basakest Please increase unit test coverage .

feat: implement updatePolicies, fix #88

feat: implement updatePolicies, fix #88

feat: implement updatePolicies, fix #88

feat: implement updatePolicies, fix #88

feat: implement updatePolicies, fix #88

feat: implement updatePolicies, fix #88
@leeqvip leeqvip merged commit 9274731 into php-casbin:master Jul 25, 2021
@leeqvip
Copy link
Member

leeqvip commented Jul 25, 2021

🎉 This PR is included in version 3.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Implement UpdatePolicies
3 participants