Fixed exception when plugin runs without options (Like "php_parallel_…

…lint: "). Issue #44
php-censor · Apr 2, 2017 · 78c66a4 · 78c66a4
1 parent a3ef15b
commit 78c66a4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/PHPCensor/Plugin/Util/Executor.php b/src/PHPCensor/Plugin/Util/Executor.php
@@ -193,7 +193,7 @@ public function executePlugin($plugin, $options)
 
         try {
             // Build and run it
-            $obj = $this->pluginFactory->buildPlugin($class, $options);
+            $obj = $this->pluginFactory->buildPlugin($class, (is_null($options) ? [] : $options));
 
             return $obj->execute();
         } catch (\Exception $ex) {

diff --git a/src/PHPCensor/Plugin/Util/Factory.php b/src/PHPCensor/Plugin/Util/Factory.php
@@ -2,6 +2,7 @@
 
 namespace PHPCensor\Plugin\Util;
 
+use PHPCensor\Plugin;
 use Pimple\Container;
 
 /**
@@ -69,7 +70,9 @@ public function getLastOptions()
      *
      * @param $className
      * @param array|null $options
+     *
      * @throws \InvalidArgumentException if $className doesn't represent a valid plugin
+     *
      * @return \PHPCensor\Plugin
      */
     public function buildPlugin($className, $options = [])
@@ -89,8 +92,10 @@ public function buildPlugin($className, $options = [])
                     $argsToUse = $this->addArgFromParam($argsToUse, $param);
                 }
             }
+            /** @var Plugin $plugin */
             $plugin = $reflectedPlugin->newInstanceArgs($argsToUse);
         } else {
+            /** @var Plugin $plugin */
             $plugin = $reflectedPlugin->newInstance();
         }