Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test pull request 3. #140

Closed
wants to merge 1 commit into from
Closed

Test pull request 3. #140

wants to merge 1 commit into from

Conversation

corpsee
Copy link
Member

@corpsee corpsee commented Dec 10, 2017

Test pull request 3.

@@ -21,8 +21,7 @@ class Application extends b8\Application
/**
* Initialise Application - Handles session verification, routing, etc.
*/
public function init()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHPCS: Expected "function abc(...)"; found "function abc (...)"

@@ -21,8 +21,7 @@ class Application extends b8\Application
/**
* Initialise Application - Handles session verification, routing, etc.
*/
public function init()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHPCS: Expected 0 spaces before opening parenthesis; 1 found

@@ -21,8 +21,7 @@ class Application extends b8\Application
/**
* Initialise Application - Handles session verification, routing, etc.
*/
public function init()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHPCS: Opening brace should be on a new line

@corpsee corpsee closed this Dec 10, 2017
@corpsee corpsee deleted the feature-pull-request-test-3 branch December 10, 2017 10:59
@codecov
Copy link

codecov bot commented Dec 10, 2017

Codecov Report

Merging #140 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #140   +/-   ##
=========================================
  Coverage     17.12%   17.12%           
  Complexity     3057     3057           
=========================================
  Files           201      201           
  Lines         12452    12452           
=========================================
  Hits           2133     2133           
  Misses        10319    10319
Impacted Files Coverage Δ Complexity Δ
src/PHPCensor/Application.php 0% <0%> (ø) 27 <8> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b65b02...08c52f3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants