Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for PHPUnit-Coverage reports in BitbucketNotify Plugin #309

Closed
wants to merge 4 commits into from
Closed

Conversation

lugark
Copy link
Contributor

@lugark lugark commented Aug 6, 2019

Contribution type

Bug fix for PHPUnit-Coverage

Description of change

  • when using PHPUnit-Coverage statistics, higher coverage was treated as bad
  • added special Class for BitbucketNotifyPhpUnitResult to see higher values as good and lower as bad

@lugark
Copy link
Contributor Author

lugark commented Aug 6, 2019

The travis-ci build is failing on the precondition to create the database:
ERROR 2002 (HY000): Can't connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2)

Unfortunately i cant restart the build - on travis-ci.com it is still working but not on travis-ci.org

@corpsee
Copy link
Member

corpsee commented Aug 6, 2019

@lugark @EugenGanshorn Thanks! I will review PR soon.

@garas
Copy link
Contributor

garas commented Aug 6, 2019

Solution for Travis MySQL issue is either add dist: trusty or services: mysql to .travis.yml.

https://travis-ci.community/t/cant-connect-to-local-mysql-server-through-socket-var-run-mysqld-mysqld-sock/3414/3

@corpsee
Copy link
Member

corpsee commented Aug 6, 2019

@garas Thank you!
@lugark Could you fix TravisCI configuration in your PR please?

@lugark
Copy link
Contributor Author

lugark commented Aug 7, 2019

@garas thx - i didnt have time to look this up yesterday
@corpsee - added both now mysql & prostgres

@corpsee
Copy link
Member

corpsee commented Aug 7, 2019

Thanks! I merged changes from the PR manually to branches release-1.1 and master (For the future release 1.1.2).

@corpsee corpsee closed this Aug 7, 2019
@corpsee
Copy link
Member

corpsee commented Aug 7, 2019

Сorrection: branch master and feature release 1.2.0.

@corpsee corpsee modified the milestones: 1.1.2, 1.2.0 Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants