Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CountryValidation: remove COUNTRY_ prefix from the constants #1036

Closed
0pdd opened this issue Jun 8, 2019 · 1 comment
Closed

CountryValidation: remove COUNTRY_ prefix from the constants #1036

0pdd opened this issue Jun 8, 2019 · 1 comment
Assignees
@php-coder
Labels
refactoring techdebt trivial
Milestone
0.4.1

Comments

@0pdd
Copy link

0pdd commented Jun 8, 2019 •
edited by php-coder

The puzzle 927-f2ec4620 from #927 has to be resolved:

mystamps/src/main/java/ru/mystamps/web/feature/country/CountryValidation.java

Line 22 in 04316e6

// @todo #927 CountryValidation: remove COUNTRY_ prefix from the constants

The puzzle was created by Slava Semushin on 08-Jun-19.
@0pdd 0pdd added the techdebt label Jun 8, 2019
0pdd referenced this issue Jun 8, 2019
@php-coder
refactor(SeriesValidation): move series-related values to the corresp…
04316e6 
…onding class.

Addressed to #927

No functional changes.
@0pdd 0pdd mentioned this issue Jun 8, 2019
Closed
14 tasks
@php-coder php-coder added this to the 0.4.1 milestone Jun 8, 2019
@php-coder php-coder self-assigned this Jun 20, 2019
@php-coder php-coder reopened this Oct 1, 2019
@php-coder
Copy link
Owner

php-coder commented Oct 1, 2019 •
edited

(There was a glitch and GitHub showed that some issue was still open on the list of the issues for 0.4.1 milestone. At the same time, GitHub didn't show what exactly issue still open. It has turned out that it was this issue. I reopened and closed it again, so now milestone statistics is shown correctly.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
refactoring techdebt trivial
Projects
None yet
Milestone
0.4.1
Development

No branches or pull requests
2 participants
@php-coder @0pdd