Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Series sale import: add integration test to check that URL can be parsed #1079

Closed
0pdd opened this issue Jul 14, 2019 · 1 comment
Closed

Series sale import: add integration test to check that URL can be parsed #1079

0pdd opened this issue Jul 14, 2019 · 1 comment
Assignees
@php-coder
Labels
area/integration tests techdebt
Milestone
0.4.5

Comments

@0pdd
Copy link

0pdd commented Jul 14, 2019 •
edited by php-coder

The puzzle 1027-ca188b93 from #1027 has to be resolved:

mystamps/src/main/java/ru/mystamps/web/feature/series/importing/HasSiteParser.java

Line 32 in 16c3c75

// @todo #1027 Series sale import: add integration test to check that URL can be parsed

The puzzle was created by Slava Semushin on 14-Jul-19.
@0pdd 0pdd added the techdebt label Jul 14, 2019
0pdd referenced this issue Jul 14, 2019
@php-coder
fix(validation): URL for import must be supported by one of the site …
16c3c75 
…parsers.

Fix #690 (/series/import/request page)
Fix #1027 (series sale import form on /series/{id} page)
This was referenced Jul 14, 2019
Closed
Closed
@php-coder
Copy link
Owner

This issue is similar to #1080 but on another page.

@php-coder php-coder mentioned this issue Jul 14, 2019
Closed
@php-coder php-coder self-assigned this Dec 30, 2020
@php-coder php-coder added this to the 0.4.5 milestone Dec 30, 2020
0pdd referenced this issue Dec 30, 2020
@php-coder
test: a url should be from one of the supported sites when we import …
a5bed04 
…a series

Fix #1080
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
area/integration tests techdebt
Projects
None yet
Milestone
0.4.5
Development

No branches or pull requests
2 participants
@php-coder @0pdd