Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize a search within user's collection #1101

Open
0pdd opened this issue Jul 24, 2019 · 2 comments
Open

Optimize a search within user's collection #1101

0pdd opened this issue Jul 24, 2019 · 2 comments
Labels
area/optimization This change could speed up our site refactoring techdebt
Milestone
0.5

Comments

@0pdd
Copy link

0pdd commented Jul 24, 2019 •
edited by php-coder

The puzzle 1098-de488059 from #1098 has to be resolved:

mystamps/src/main/java/ru/mystamps/web/feature/series/SeriesController.java

Line 511 in 742b7d8

// @todo #1098 Optimize a search within user's collection

The puzzle was created by Slava Semushin on 24-Jul-19.
@0pdd 0pdd added the techdebt label Jul 24, 2019
0pdd referenced this issue Jul 24, 2019
@php-coder
style(SeriesController): add @todo comment with technical debt.
742b7d8 
Should be in bee2754 commit.

[skip ci]
@0pdd 0pdd mentioned this issue Jul 24, 2019
Closed
@php-coder php-coder added refactoring area/optimization This change could speed up our site labels Jul 24, 2019
@php-coder
Copy link
Owner

php-coder commented Jul 24, 2019 •
edited

What we can improve here:

  • N+1 queries could be easily reduced to 2 if CollectionService.isSeriesInCollection() will be modified to take varargs instead of a single series
  • (ideally) we should search in user's collections only (at this moment we first search on site database and later removes everything that user doesn't have in its collection)
  • it's own service method should/could be introduced

@php-coder
Copy link
Owner

After #1123 we don't use CollectionService.isSeriesInCollection() on collection info page, so now it's being used only for search in a collection.

@php-coder php-coder added this to the 0.4.6 milestone Jan 12, 2021
@php-coder php-coder modified the milestones: 0.4.6, 0.4.7 Feb 1, 2021
@php-coder php-coder modified the milestones: 0.4.7, 0.5 Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/optimization This change could speed up our site refactoring techdebt
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
2 participants
@php-coder @0pdd