Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Togglz: remove items left from >= 0.4.1 milestone #1121

Closed
0pdd opened this issue Sep 9, 2019 · 1 comment
Closed

Togglz: remove items left from >= 0.4.1 milestone #1121

0pdd opened this issue Sep 9, 2019 · 1 comment
Assignees
Labels
environment/prod Issue affects only production environment refactoring techdebt
Milestone

Comments

@0pdd
Copy link

0pdd commented Sep 9, 2019

The puzzle 605-2e5a00b2 from #605 has to be resolved:

// @todo #605 Togglz: remove items left from >= 0.4.1 milestone

The puzzle was created by Slava Semushin on 09-Sep-19.

@0pdd 0pdd added the techdebt label Sep 9, 2019
@php-coder php-coder added this to the 0.5 milestone Sep 9, 2019
@php-coder php-coder modified the milestones: 0.5, 0.4.3 Dec 11, 2019
@php-coder php-coder added the environment/prod Issue affects only production environment label Mar 11, 2020
@php-coder php-coder self-assigned this Mar 11, 2020
@php-coder
Copy link
Owner

I looked on prod and I see that Togglz doesn't persist all these old features:

mysql> select * from TOGGLZ;
+---------------------------------+-----------------+-------------+-----------------+
| FEATURE_NAME                    | FEATURE_ENABLED | STRATEGY_ID | STRATEGY_PARAMS |
+---------------------------------+-----------------+-------------+-----------------+
| ADD_ADDITIONAL_IMAGES_TO_SERIES |               1 | NULL        | NULL            |
| CSP_REPORT_ONLY                 |               0 | NULL        | NULL            |
+---------------------------------+-----------------+-------------+-----------------+
2 rows in set (0.00 sec)

So, only ADD_ADDITIONAL_IMAGES_TO_SERIES needs to be cleaned up in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
environment/prod Issue affects only production environment refactoring techdebt
Projects
None yet
Development

No branches or pull requests

2 participants