-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate year of release #7
Comments
Because we already have a check for the year in future (see #8) then here we just need to check that the year >= 1840. I suggest to use |
Ага, а я думал - на стороне клиента проверку реализовать. |
Technically it's already "validated" on the client side -- there is a select with options from 1840 to 2016. So, user couldn't choose the year less than 1840. But... this check intended not for ordinary users :) |
Year, angry users may want to put your app down, right? |
:-) No, probably, it can't break the application, but a) I want to be sure that my data satisfies the constraints b) it's a trivial task that could be accomplished by newcomers :) BTW, if we would use PostgreSQL, for instance, we could add a Another idea about protecting the data is: maybe we would write some logic that operates on the series' year and if someone put |
Add
year
field validation at series creation page. It must be inside range [1840, $currentYear].The text was updated successfully, but these errors were encountered: