Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestObjects: introduce name generator for top categories #737

Closed
0pdd opened this issue Dec 2, 2017 · 1 comment
Closed

TestObjects: introduce name generator for top categories #737

0pdd opened this issue Dec 2, 2017 · 1 comment
Assignees
@php-coder
Labels
area/unit tests refactoring resolution/wontfix techdebt
Milestone
0.4

Comments

@0pdd
Copy link

0pdd commented Dec 2, 2017 •
edited by php-coder

The puzzle 548-b1a11750 (from #548) in src/test/java/ru/mystamps/web/service/TestObjects.java (lines 207-207) has to be resolved: "Introduce name generator for top categories"

The puzzle was created by Slava Semushin on 30-Nov-17.

Tech debt for: 4d140fb (#548 )
0pdd referenced this issue Dec 2, 2017
@php-coder
CategoryServiceImpl.findCategoriesWithParents(): add unit test.
4d140fb 
Fix #548
@php-coder php-coder changed the title TestObjects.java:207-207: Introduce name generator for top... TestObjects: Introduce name generator for top categories Dec 2, 2017
@php-coder php-coder changed the title TestObjects: Introduce name generator for top categories TestObjects: introduce name generator for top categories Dec 2, 2017
@php-coder php-coder self-assigned this Dec 18, 2017
@php-coder php-coder added this to the 0.4 milestone Dec 18, 2017
@0pdd
Copy link
Author

0pdd commented Dec 18, 2017

The puzzle 548-b1a11750 has disappeared from the source code, that's why I closed this issue.

@0pdd 0pdd closed this as completed Dec 18, 2017
0pdd referenced this issue Dec 18, 2017
@php-coder
GroupByParent.transformCategories(): replace CategoryDto by EntityWit…
eb606cc 
…hParentDto.

Fix #744

No functional changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@php-coder php-coder

Labels
area/unit tests refactoring resolution/wontfix techdebt
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
2 participants
@php-coder @0pdd