Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Series import: validate app.site-parser[x].currency-value #842

Closed
0pdd opened this issue Feb 3, 2018 · 1 comment
Closed

Series import: validate app.site-parser[x].currency-value #842

0pdd opened this issue Feb 3, 2018 · 1 comment

Comments

@0pdd
Copy link

0pdd commented Feb 3, 2018

The puzzle 695-707db4aa from #695 has to be resolved:

// @todo #695 Series import: validate app.site-parser[x].currency-value

The puzzle was created by Slava Semushin on 04-Jan-18.

Estimate: 0 minutes, role: IMP.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@php-coder
Copy link
Owner

After fixing #975 the properties will live in database and we won't have code that validates the properties (see also #751). I'm not sure that we need validation for them at this stage because such errors should not happen as only admin adds these properties to database. Even if they occurs, the chance is really small and in that case we may circle back to this discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants