Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/series/import/request/{id}(seriesSale): add integration test for validation of required fields #846

Open
0pdd opened this issue Feb 3, 2018 · 1 comment
Open

/series/import/request/{id}(seriesSale): add integration test for validation of required fields #846

0pdd opened this issue Feb 3, 2018 · 1 comment
Labels
area/integration tests techdebt

Comments

@0pdd
Copy link

0pdd commented Feb 3, 2018

The puzzle 695-0c97d8b1 from #695 has to be resolved:

mystamps/src/main/java/ru/mystamps/web/controller/dto/ImportSeriesSalesForm.java

Lines 33 to 34 in ebe7721

// @todo #695 /series/import/request/{id}(seriesSale):
// add integration test for validation of required fields

The puzzle was created by Slava Semushin on 04-Jan-18.

Estimate: 0 minutes, role: IMP.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd 0pdd added the techdebt label Feb 3, 2018
0pdd referenced this issue Feb 3, 2018
@php-coder
Change URL for a test series info page to make it more consisten with…
ebe7721 
… others.

Should be in 0814b35 commit.

Addressed to #695

No functional changes.
@php-coder
Copy link
Owner

After fixing #695 sellerId is now only required when there is no sellerName/sellerUrl.

@0pdd 0pdd mentioned this issue Jul 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/integration tests techdebt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@php-coder @0pdd