Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JdbcSeriesImportDao.changeStatus(): introduce dto #897

Closed
0pdd opened this issue Jul 5, 2018 · 0 comments
Closed

JdbcSeriesImportDao.changeStatus(): introduce dto #897

0pdd opened this issue Jul 5, 2018 · 0 comments
Assignees
@KrivenkoAlexander
Labels
refactoring techdebt trivial
Milestone
0.4

Comments

@0pdd
Copy link

0pdd commented Jul 5, 2018 •
edited by php-coder

The puzzle 660-d185398d from #660 has to be resolved:

mystamps/src/main/java/ru/mystamps/web/dao/impl/JdbcSeriesImportDao.java

Line 134 in 74259de

// @todo #660 JdbcSeriesImportDao.changeStatus(): introduce dao

The puzzle was created by Slava Semushin on 05-Jul-18.

We need to modify changeStatus() method in the JdbcSeriesImportDao class. At this moment it has 4 arguments and we need to extract them into a single class. I suggest to give it a name UpdateImportRequestStatusDbDto.

The class has been renamed some time ago and now its new location is src/main/java/ru/mystamps/web/feature/series/importing/JdbcSeriesImportDao.java
@0pdd 0pdd added the techdebt label Jul 5, 2018
0pdd referenced this issue Jul 5, 2018
@php-coder
JdbcSeriesImportDao: convert simple TODO comments to comments recogni…
74259de 
…zable by 0pdd.

Should be in 29f6dc9 commit.

No code changes.
@0pdd 0pdd mentioned this issue Jul 5, 2018
Closed
@php-coder php-coder added this to the 0.4 milestone Feb 6, 2019
@php-coder php-coder changed the title JdbcSeriesImportDao.changeStatus(): introduce dao JdbcSeriesImportDao.changeStatus(): introduce dto Feb 6, 2019
@php-coder php-coder mentioned this issue Feb 6, 2019
Closed
@KrivenkoAlexander KrivenkoAlexander mentioned this issue Feb 9, 2019
Closed
@php-coder php-coder mentioned this issue Feb 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KrivenkoAlexander KrivenkoAlexander

Labels
refactoring techdebt trivial
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
3 participants
@php-coder @KrivenkoAlexander @0pdd