Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename vendor #228

Merged
merged 2 commits into from
Aug 31, 2017
Merged

Rename vendor #228

merged 2 commits into from
Aug 31, 2017

Conversation

localheinz
Copy link
Contributor

This PR

  • renames references to the vendor satooshi to php-coveralls

πŸ’β€β™‚οΈ Not sure, are we planning to rename

  • namespaces
  • package name

as well?

@keradus
Copy link
Member

keradus commented Aug 20, 2017

Let me first set-up the integrations

@keradus
Copy link
Member

keradus commented Aug 31, 2017

please rebase to retrigger travis

@localheinz
Copy link
Contributor Author

@keradus

Let me know if you'd like me to rename Satooshi to PhpCoveralls, too!

@keradus
Copy link
Member

keradus commented Aug 31, 2017

yes

@keradus
Copy link
Member

keradus commented Aug 31, 2017

let me merge #227 first to avoid conflicts ?

@keradus
Copy link
Member

keradus commented Aug 31, 2017

merged

@keradus keradus changed the title Fix: Rename vendor Rename vendor Aug 31, 2017
@localheinz localheinz force-pushed the fix/rename branch 2 times, most recently from 020f337 to d1be877 Compare August 31, 2017 22:30
@keradus
Copy link
Member

keradus commented Aug 31, 2017

code looks great, let me wait for Travis

@SpacePossum
Copy link

7.1 failed :( sorry

@keradus
Copy link
Member

keradus commented Aug 31, 2017

@localheinz please don't squash in future
what was the issue for 7,1 ?

@SpacePossum
Copy link

SpacePossum commented Aug 31, 2017

code coverage IIRC
I did not IIRC

@localheinz
Copy link
Contributor Author

@keradus

$ php dev-tools/vendor/bin/php-cs-fixer fix  -vv
Loaded config default from "/Users/am/Sites/php-coveralls/php-coveralls/.php_cs.dist".
...............F.........F..............F.....
Legend: ?-unknown, I-invalid file syntax, file ignored, S-Skipped, .-no changes, F-fixed, E-error
   1) tests/PhpCoveralls/Bundle/CoverallsBundle/Repository/JobsRepositoryTest.php (ordered_imports)
   2) src/PhpCoveralls/Bundle/CoverallsBundle/Command/CoverallsJobsCommand.php (ordered_imports)
   3) src/PhpCoveralls/Bundle/CoverallsBundle/Repository/JobsRepository.php (ordered_imports)

Fixed all files in 6.428 seconds, 13.500 MB memory used

@localheinz
Copy link
Contributor Author

Thanks for pointing out, @SpacePossum!

@keradus
Copy link
Member

keradus commented Aug 31, 2017

later, I will reconfigure travis to have proper jobs instead of build matrix

@keradus keradus merged commit e258624 into php-coveralls:master Aug 31, 2017
@localheinz
Copy link
Contributor Author

Thank you, @keradus!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants