Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module not compatible with M2.2 #15

Closed
Tjitse-E opened this issue Sep 29, 2017 · 11 comments
Closed

Module not compatible with M2.2 #15

Tjitse-E opened this issue Sep 29, 2017 · 11 comments

Comments

@Tjitse-E
Copy link

Tjitse-E commented Sep 29, 2017

Did anyone test if the module works on M2.2?

Trying to run an Magento 2.2 update:

- php-cuong/magento2-faqs-extensions 2.1.0 requires magento/module-backend 100.0.*|100.1.*
-> satisfiable by magento/module-backend[100.1.4, 100.0.4, 100.1.1, 100.0.6, 100.0.11, 100.0.10, 100.1.2, 100.0.2, 100.0.8, 100.1.3, 100.1.0-rc3, 100.0.5, 100.1.0, 100.1.0-rc1, 100.0.7, 100.0.3, 100.0.9, 100.1.0-rc2].
@gewaechshaus
Copy link

@Tjitse-E - Same result here...

@woutersamaey
Copy link

+1

@samoudi2006
Copy link

module is not compatible M2.2

@Tjitse-E
Copy link
Author

@woutersamaey , @samoudi2006 , i've forked the repo and added support for M2.2. myself. Checkout PR #16. Everything works fine here with M2.2 and PHP 7.1.

@gewaechshaus
Copy link

@Tjitse-E - many thanks!
Can you edit the faqs in backend? I am still running into

Class PHPCuongFaqFaqGridDataProvider does not exist

@Tjitse-E
Copy link
Author

@gewaechshaus I don't have any troubles editing faqs in the backend. What steps are you taking exactly?

@gewaechshaus
Copy link

gewaechshaus commented Oct 25, 2017

@Tjitse-E - I just cloned your repo and did a setup: upgrade di:compile etc., Think I will have to investigate it... Maybe just missing files.

@moneef
Copy link

moneef commented Oct 25, 2017

Hey @Tjitse-E,

i'm facing few issues with this module i hope you could help me as i'm currently broke and the author ask for fee on requests and sure ill pay him or you when i get funds.

1- first issue is with .html appending how can i remove it or add an option on adminhtml to chose to append it or not.

2- second issue with non-latin letters, when i input Arabic letters for category name its URL dosn't work anymore

@Tjitse-E
Copy link
Author

@moneef please open a new issue for this, this issue is about Magento 2.2 compatibility

@moneef
Copy link

moneef commented Oct 25, 2017

@Tjitse-E sure. thanks for guiding me.

@gewaechshaus
Copy link

gewaechshaus commented Oct 26, 2017

@Tjitse-E - see PR #18 for fixing the issue I described above...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants